Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Tome API Updates #479

Merged
merged 6 commits into from
Jan 23, 2024
Merged

[feature] Tome API Updates #479

merged 6 commits into from
Jan 23, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind cleanup

What this PR does / why we need it:

  • Removes unused agent GraphQL API and related tests
  • Adds new updateTome and deleteTome GraphQL API admin methods
  • Adds new support_model and tactic enum types to Tome
  • Adds new author required field to Tome
  • Adds new uploader optional edge to Tome
  • Sets author, support_model, and tactic information for all first party tomes
  • Adds new test cases for relevant features

Which issue(s) this PR fixes:

Fixes #130
Fixes #467
Fixes #468
Fixes #469

@KCarretto KCarretto requested a review from hulto January 23, 2024 01:43
Cictrone
Cictrone previously approved these changes Jan 23, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Major Achievement; Biden

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good boss man o7

@KCarretto KCarretto merged commit 4fc3fab into main Jan 23, 2024
6 checks passed
@KCarretto KCarretto deleted the tome-api branch January 23, 2024 01:57
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
[feature] Tome API Updates (#479)

* Added author field, removed old GraphQL agent API methods

* Add functionality to track tome uploader, remove unused GraphQL API tests

* Added UpdateTome & DeleteTome API

* Set default tome support model & tactics

* Remove UploaderID from create & update tome mutations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants