Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to private fork of starlark with patch. #48

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Sep 11, 2022

What type of PR is this?

What this PR does / why we need it:

This PR fixes an issue with the upstream star-lark crate.

Here is the modified code base the backtrace function was modified to compile under nightly-2021-11-22

https://github.com/hulto/starlark-rust/tree/v0.6.0-patch

Which issue(s) this PR fixes:

Fixes #47

@hulto hulto linked an issue Sep 11, 2022 that may be closed by this pull request
@hulto
Copy link
Collaborator Author

hulto commented Sep 11, 2022

starlark-rust patch diff
image

@hulto hulto added the bug Something isn't working label Sep 11, 2022
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We gotta change this back asap

@hulto hulto merged commit 97836e3 into main Sep 12, 2022
@hulto hulto deleted the 47-bug-starlark-package-appears-to-be-broken branch September 12, 2022 02:13
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Switched to private fork of starlark with patch. (#48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Starlark package appears to be broken
2 participants