Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix file download #567

Merged
merged 4 commits into from
Feb 10, 2024
Merged

[bug] Fix file download #567

merged 4 commits into from
Feb 10, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes our assets.copy implementation, as well as an issue with how imix was downloading files for tasks.

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits then good.

tavern/tomes/example/main.eldritch Outdated Show resolved Hide resolved
implants/imix/src/task.rs Outdated Show resolved Hide resolved
implants/lib/c2/src/grpc.rs Outdated Show resolved Hide resolved
@Cictrone
Copy link
Collaborator

also apparently windows is madge lol (what's new?)

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (5f185bd) 69.75% compared to head (8b94264) 70.32%.

Files Patch % Lines
implants/lib/c2/src/grpc.rs 0.00% 19 Missing ⚠️
implants/imix/src/task.rs 0.00% 9 Missing ⚠️
implants/lib/eldritch/src/assets/copy_impl.rs 98.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   69.75%   70.32%   +0.56%     
==========================================
  Files         139      139              
  Lines       10071    10149      +78     
==========================================
+ Hits         7025     7137     +112     
+ Misses       2880     2846      -34     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KCarretto KCarretto merged commit 1c8eff8 into main Feb 10, 2024
8 checks passed
@KCarretto KCarretto deleted the assets-copy-fixes branch February 10, 2024 21:54
nullmonk pushed a commit that referenced this pull request Feb 14, 2024
* fix file download

* fix nits

* fix tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants