-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Refactor Eldritch Library Registration #579
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 71.28% 71.83% +0.54%
==========================================
Files 141 142 +1
Lines 10092 9955 -137
==========================================
- Hits 7194 7151 -43
+ Misses 2732 2638 -94
Partials 166 166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits otherwise LGTM
docs/_docs/dev-guide/eldritch.md
Outdated
@@ -376,7 +419,8 @@ mod tests { | |||
} | |||
``` | |||
|
|||
### Async PR example | |||
#### Async PR example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably remove this too since it's no longer a good reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sheeesh
* added eldritch_lib macro, moved to mod.rs * updated docs * fix nits
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
eldritch_lib!()
macro for defining librariesif false
)mod.rs
to cleanup the eldritch root directory