-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Import Tomes from git #603
Conversation
…into github-imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Optionally, specify directories to include. | ||
Only tomes that have a main.eldritch in one of these directory prefixes will be included. | ||
""" | ||
includeDirs: [String!] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this search recursizely? Eg do i need to specify:
gitURL: https://github.com/spellshift/realm
includeDirs: ["tavern/tomes/"]
- or -
includeDirs: ["tavern/tomes/cat","/tavern/tomes/hostname",...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tavern/tomes/
, all it does is a prefix match
…into github-imports
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
- Coverage 71.53% 71.18% -0.35%
==========================================
Files 167 168 +1
Lines 11002 11199 +197
==========================================
+ Hits 7870 7972 +102
- Misses 2953 3023 +70
- Partials 179 204 +25 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a new GraphQL Mutation which will import tomes from the provided git URI.