-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows default install #605
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
+ Coverage 67.84% 71.53% +3.69%
==========================================
Files 167 167
Lines 10420 11002 +582
==========================================
+ Hits 7069 7870 +801
+ Misses 3172 2953 -219
Partials 179 179 ☔ View full report in Codecov by Sentry. |
create_res = sys.shell("sc.exe create "+service_name+" binpath= "+executable_path+" displayname="+service_display_name+" start= auto type= own") | ||
if 'ERROR' in create_res['stdout'] or create_res['stderr'] != "": | ||
print("Failed to create service:\n") | ||
print(create_res) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: combine these into one print statement
print("failed to create service:\n"+create_rest+"\n")
implants/imix/src/main.rs
Outdated
@@ -3,14 +3,24 @@ | |||
#[macro_use] | |||
extern crate windows_service; | |||
|
|||
use imix::handle_main; | |||
use imix::{handle_main}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the {}
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a default way for imix users to install on windows.
Fix imix service build allowing it to run as a regular exe as well.