Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Remove file for assets.copy() instead of truncating #651

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Updates assets.copy to remove files instead of truncating them. This will prevent the error "Text file busy (os error 26)" when attempting to overwrite a file that is currently in use by a running process.

@KCarretto KCarretto requested a review from hulto February 21, 2024 22:13
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cictrone Cictrone merged commit d15355f into main Feb 21, 2024
6 checks passed
@Cictrone Cictrone deleted the asset-copy-no-truncate branch February 21, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants