Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

622 file list tome doesnt support relative paths #671

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Feb 26, 2024

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

  • fixes file_list tome
  • Moves file.list eldritch tests to new end to end style

Which issue(s) this PR fixes:

Fixes #622

@hulto hulto linked an issue Feb 26, 2024 that may be closed by this pull request
KCarretto
KCarretto previously approved these changes Feb 26, 2024
implants/lib/eldritch/src/file/list_impl.rs Show resolved Hide resolved
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.03%. Comparing base (4fe7369) to head (17a05be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   71.76%   72.03%   +0.27%     
==========================================
  Files         175      175              
  Lines       12111    12219     +108     
==========================================
+ Hits         8691     8802     +111     
+ Misses       3205     3202       -3     
  Partials      215      215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hulto hulto merged commit c468a7e into main Feb 27, 2024
8 checks passed
@hulto hulto deleted the 622-file_list-tome-doesnt-support-relative-paths branch February 27, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file_list tome doesn't support relative paths
2 participants