Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created core ents and implemented createJob mutation #83

Merged
merged 19 commits into from
Nov 22, 2022
Merged

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature

/kind api-change

What this PR does / why we need it:

Updates our ents, adds appropriate fields, uses mixins and hooks for optimal code reuse and bug avoidance, and implements the createJob mutation (with tests!).

Which issue(s) this PR fixes:

Maybe I should make issues first

@KCarretto KCarretto requested a review from hulto November 19, 2022 01:09
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes:

  • Move .devcontainer changes to a seperate PR.
  • Change test to use managed resources.

.devcontainer/devcontainer.json Show resolved Hide resolved
entgql.Skip(entgql.SkipMutationCreateInput),
).
Comment("Bundle file that the executing tome depends on (if any)").
Unique(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the file resources used inside the tome?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir o7

@@ -15,13 +15,30 @@ type Task struct {
// Fields of the Task.
func (Task) Fields() []ent.Field {
return []ent.Field{
field.String("name").
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No task names? Are we only using the unique ID to reference tasks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jobs have the name, and tasks have an edge to the job

tavern/graphql/query_test.go Show resolved Hide resolved
@KCarretto KCarretto merged commit cc883de into main Nov 22, 2022
@KCarretto KCarretto deleted the ent-dev branch November 22, 2022 04:49
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
Created core ents and implemented createJob mutation (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants