Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SubmitTaskResult mutation and test #94

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Adds the submitTaskResult mutation and related test, which will enable agents to report output (and errors) from task execution.

@KCarretto KCarretto requested a review from hulto February 7, 2023 03:25
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


"""
Output captured as the result of task execution.
Submitting multiple outputs will result in appending new output to the previous output.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat. I'll try to make the ASYNC futures buffer readable so I can send live updates.

Would be nice for long lived tasks like key logging.

@KCarretto KCarretto merged commit 4ef277d into main Feb 7, 2023
@KCarretto KCarretto deleted the submit-task-result branch February 7, 2023 05:41
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
Added SubmitTaskResult mutation and test (#94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants