Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Fix imports from fontawesome-common-types for clean build #642

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

myl7
Copy link
Collaborator

@myl7 myl7 commented May 10, 2022

According to the description of @fortawesome/fontawesome-common-types:

If you are trying to import types from this package we highly recommend you do the following instead as all types in this package are re-exported to the main fontawesome package.

import { IconName } from `@fortawesome/fontawesome-svg-core`

Actually when building the project in a node:18-alpine Docker container, next build will complain the compiler SWC can not find types of @fortawesome/fontawesome-common-types and fails, but @fortawesome/fontawesome-svg-core will be OK. The PR may help users who want to build the project in a container to selfhost it.

@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
onedrive-vercel-index ✅ Ready (Inspect) Visit Preview May 10, 2022 at 3:21AM (UTC)

@myl7 myl7 merged commit ecb0e6a into spencerwooo:main Jul 15, 2022
@myl7 myl7 deleted the fix-fontawesome-common-types-import branch July 15, 2022 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant