Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Builder take a FileSource #194

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

spenserblack
Copy link
Owner

@spenserblack spenserblack commented Sep 26, 2023

While this does not provide other file sources, it makes it possible to add them. Even external libraries can define their own file sources to be used, so this closes #149.

@spenserblack spenserblack added the semver-major This pull request bumps the major version label Sep 26, 2023
@spenserblack spenserblack enabled auto-merge (squash) September 26, 2023 14:20
The up-to-date example has been moved to the root module's doc comment.
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #194 (b9469f3) into main (e84c746) will decrease coverage by 0.44%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   83.12%   82.69%   -0.44%     
==========================================
  Files          16       16              
  Lines         569      572       +3     
==========================================
  Hits          473      473              
- Misses         96       99       +3     
Flag Coverage Δ
82.69% <66.66%> (-0.44%) ⬇️
macOS-latest 82.48% <66.66%> (-0.44%) ⬇️
ubuntu-latest 77.71% <66.66%> (-0.43%) ⬇️
windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gengo/src/builder.rs 100.00% <100.00%> (ø)
gengo/src/lib.rs 85.71% <ø> (ø)
gengo-bin/src/cli.rs 86.36% <50.00%> (-2.93%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spenserblack spenserblack merged commit 2b1bf09 into main Sep 26, 2023
@spenserblack spenserblack deleted the chore/builder-takes-filesource branch September 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major This pull request bumps the major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple file sources
1 participant