Skip to content

Commit

Permalink
Add failing test for reading a small zip file
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnStarich committed Jun 26, 2020
1 parent 1524d0a commit fc99a5d
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 0 deletions.
43 changes: 43 additions & 0 deletions zipfs/file_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
package zipfs

import (
"archive/zip"
"io"
"testing"
)

func TestFileRead(t *testing.T) {
zrc, err := zip.OpenReader("testdata/small.zip")
if err != nil {
t.Fatal(err)
}
zfs := New(&zrc.Reader)
f, err := zfs.Open("smallFile")
if err != nil {
t.Fatal(err)
}
info, err := f.Stat()
if err != nil {
t.Fatal(err)
}
chunkSize := info.Size() * 2 // read with extra large buffer

buf := make([]byte, chunkSize)
n, err := f.Read(buf)
if err != io.EOF {
t.Fatal("Failed to read file to completion:", err)
}
if n != int(info.Size()) {
t.Errorf("Expected read length to be %d, found: %d", info.Size(), n)
}

// read a second time to check f.offset and f.buf are correct
buf = make([]byte, chunkSize)
n, err = f.Read(buf)
if err != io.EOF {
t.Fatal("Failed to read a fully read file:", err)
}
if n != 0 {
t.Errorf("Expected read length to be 0, found: %d", n)
}
}
Binary file added zipfs/testdata/small.zip
Binary file not shown.

0 comments on commit fc99a5d

Please sign in to comment.