Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming a dir with sub-directories #180

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion memmap.go
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ func (m *MemMapFs) RemoveAll(path string) error {
defer m.mu.RUnlock()

for p, _ := range m.getData() {
if strings.HasPrefix(p, path) {
if strings.HasPrefix(p, path+FilePathSeparator) {
m.mu.RUnlock()
m.mu.Lock()
delete(m.getData(), p)
Expand Down Expand Up @@ -305,6 +305,18 @@ func (m *MemMapFs) Rename(oldname, newname string) error {
} else {
return &os.PathError{Op: "rename", Path: oldname, Err: ErrFileNotFound}
}

for p, fileData := range m.getData() {
if strings.HasPrefix(p, oldname+FilePathSeparator) {
m.mu.RUnlock()
m.mu.Lock()
delete(m.getData(), p)
p := strings.Replace(p, oldname, newname, 1)
m.getData()[p] = fileData
m.mu.Unlock()
m.mu.RLock()
}
}
return nil
}

Expand Down
44 changes: 44 additions & 0 deletions memmap_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -449,3 +449,47 @@ func TestMemFsUnexpectedEOF(t *testing.T) {
t.Fatal("Expected ErrUnexpectedEOF")
}
}

func TestMemFsRenameDir(t *testing.T) {
const srcPath = "/src"
const dstPath = "/dst"
const subDir = "dir"

fs := NewMemMapFs()

err := fs.MkdirAll(srcPath+FilePathSeparator+subDir, 0777)
if err != nil {
t.Errorf("MkDirAll failed: %s", err)
return
}

err = fs.Rename(srcPath, dstPath)
if err != nil {
t.Errorf("Rename failed: %s", err)
return
}

_, err = fs.Stat(srcPath + FilePathSeparator + subDir)
if err == nil {
t.Errorf("SubDir still exists in the source dir")
return
}

_, err = fs.Stat(dstPath + FilePathSeparator + subDir)
if err != nil {
t.Errorf("SubDir stat in the destination dir: %s", err)
return
}

err = fs.Mkdir(srcPath, 0777)
if err != nil {
t.Errorf("Cannot recreate the source dir: %s", err)
return
}

err = fs.Mkdir(srcPath+FilePathSeparator+subDir, 0777)
if err != nil {
t.Errorf("Cannot recreate the subdir in the source dir: %s", err)
return
}
}