Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update viper dependency #1013

Closed
egaudet opened this issue Jan 6, 2020 · 2 comments · Fixed by #1012
Closed

Update viper dependency #1013

egaudet opened this issue Jan 6, 2020 · 2 comments · Fixed by #1012

Comments

@egaudet
Copy link

egaudet commented Jan 6, 2020

Viper 1.3.2 is not goroutine safe and causes race conditions for any code using Set/Get from multiple goroutines. Packages that use both cobra and viper are forced to use the unsafe version of viper.
@umarcor
Copy link
Contributor

umarcor commented Jan 7, 2020 •
edited
Loading

Cobra currently uses Viper 1.4.0: https://github.com/spf13/cobra/blob/master/go.mod#L10. Anyway, see #1012.

@umarcor umarcor mentioned this issue Jan 7, 2020
Merged
@github-actions
Copy link

github-actions bot commented Apr 3, 2020

This issue is being marked as stale due to a long period of inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update viper, pflag and yaml umarcor/cobra
2 participants
@egaudet @umarcor