Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update viper, pflag and yaml #1012

Merged
merged 1 commit into from
Jul 13, 2020
Merged

update viper, pflag and yaml #1012

merged 1 commit into from
Jul 13, 2020

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Jan 4, 2020 •
edited
Loading

Close #1013

This PR updates pflag, viper and yaml to the latest stable releases.

Refs: #962, #954, #1091, #1128

@umarcor umarcor force-pushed the update-deps branch 2 times, most recently from d86600d to 3b87407 Compare January 6, 2020 18:29
@umarcor umarcor mentioned this pull request Jan 7, 2020
Closed
@umarcor
Copy link
Contributor Author

umarcor commented Apr 13, 2020

Updated and rebased.

@umarcor umarcor mentioned this pull request Apr 13, 2020
Closed
@umarcor umarcor mentioned this pull request May 11, 2020
Closed
@umarcor umarcor mentioned this pull request Jun 1, 2020
Closed
@umarcor umarcor mentioned this pull request Jul 11, 2020
Merged
@umarcor
Copy link
Contributor Author

umarcor commented Jul 11, 2020

yaml was updated separatedly in #1153. This PR now updates viper and pflag only.

jpmcb
jpmcb approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the pflags and viper releases, doesn't seem like there is anything breaking. The tests are passing so this should be good to go! 👍

@jpmcb jpmcb merged commit 884edc5 into spf13:master Jul 13, 2020
@umarcor umarcor deleted the update-deps branch July 13, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update viper dependency
2 participants
@umarcor @jpmcb