Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Revert of #922 #1068

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

jharshman
Copy link
Collaborator

@jharshman jharshman commented Mar 26, 2020

Issue Reference: #1056
Bug Introduced: #922

#922 Introduced a new error type that emitted when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1.

This change reverts the addition of that new error. Similar
functionality can be accomplished by leveraging RunE.

@jharshman jharshman added the kind/bug A bug in cobra; unintended behavior label Mar 26, 2020
@jharshman jharshman mentioned this pull request Mar 26, 2020
@jharshman
Copy link
Collaborator Author

fixes: #1056

@jharshman jharshman requested a review from n10v March 26, 2020 22:07
@jharshman
Copy link
Collaborator Author

@BoGeM tagging you as a reviewer here as you were on #922

Issue Reference: spf13#1056

spf13#922 introduced a new error
type that emitted when a command was not runnable. This caused
all commands w/o a run function set to error w/ that message and a status code of 1.

This change reverts the addition of that new error. Similar
functionality can be accomplished by leveraging RunE.
Copy link
Collaborator

@n10v n10v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would not review anymore as the PRs I review end up being reverted haha 😅

@n10v
Copy link
Collaborator

n10v commented Mar 27, 2020

I didn't contribute in cobra since 2018, so I already lost the context :(

@jharshman jharshman merged commit 6607e6b into spf13:master Mar 27, 2020
@ob-stripe
Copy link

@jharshman Thanks for the quick fix! Do you plan on releasing a new version of cobra soon?

@jharshman
Copy link
Collaborator Author

@ob-stripe it's already been released.
v0.0.7

@ob-stripe
Copy link

🚀 Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in cobra; unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants