Fix command name collision on generator #1447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating new commands via `cobra add`, it is not possible to add commands with the same name to different parents. They will just overwrite each other. With this patch, the command's object identifier is templated `parentCommandCmd`, the `Use` field `command` and the file name `parent_command.go`. Fixes #1059 Fixes #1131 Signed-off-by: Carlos Marx <me@carlosmarx.com>
|
|
github-actions
bot
added
the
area/cli [deprecated]
|
This PR is being marked as stale due to a long period of inactivity |
hoshsadiq
pushed a commit
to zulucmd/zulu
that referenced
this pull request
Dec 31, 2022
When creating new commands via `cobra add`, it is not possible to add commands with the same name to different parents. They will just overwrite each other. With this patch, the command's object identifier is templated `parentCommandCmd`, the `Use` field `command` and the file name `parent_command.go`. Merge spf13/cobra#1447 Fixes #1059 Fixes #1131 Signed-off-by: Carlos Marx <me@carlosmarx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new commands via
cobra add, it is not possible to addcommands with the same name to different parents. They will just
overwrite each other.
With this patch, the command's object identifier is templated
parentCommandCmd, theUsefieldcommandand the file nameparent_command.go.Fixes #1059
Fixes #1131
Signed-off-by: Carlos Marx me@carlosmarx.com