-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace viper with useViper in cobra/README.md' example .cobra.yaml #1571
fix: replace viper with useViper in cobra/README.md' example .cobra.yaml #1571
Conversation
Why do you just ignore this pull request... |
To optimise the limited time of the maintainers (there are very few), PRs are usually merged around release time. Thanks for your contribution though and don't despair 😀 |
I can confirm that setting Thanks @acehinnnqru for finding this. |
@acehinnnqru The cobra-cli code generator has recently been moved to https://github.com/spf13/cobra-cli along with its README. The section you are modifying will disappear from this repo when #1604 is merged. Would you be able to submit a new PR to https://github.com/spf13/cobra-cli that makes the same change but to https://github.com/spf13/cobra-cli/blob/7c6e26ac0939450323b7dd4acf8d8280dde3879e/README.md?plain=1#L138 I will not take long to merge it 😉 Sorry for the annoyance, and thank you. |
I think it's unnecessary to submit a new PR if the typo is fix. And I will close this PR... Thank you for your attention of this PR. |
Actually, the typo is not fixed in the new repo: https://github.com/spf13/cobra-cli/blob/74762ac083f2c4deffef229c887ffc15beb6ce0d/README.md?plain=1#L138 |
OK, I will open a new PR in the new repo. Thanks. |
I found the example .cobra.yaml's config "viper" is not working; I think it is useViper after I have read the source code.