Check for group presence after full initialization #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marckhouzam
force-pushed
the
fix/noOrderForGroups
branch
from
b598d78 to
6333566
Compare
github-actions
bot
removed
the
area/cobra-command
marckhouzam
force-pushed
the
fix/noOrderForGroups
branch
from
6333566 to
ddc80d1
Compare
aawsome
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Very good idea @marckhouzam to put this check in the execute branch!
I've got only nit-picking comments; -)
marckhouzam
force-pushed
the
fix/noOrderForGroups
branch
from
ddc80d1 to
09b9899
Compare
Fixes spf13#1831 By moving the check for help group existence to "ExecuteC()" we no longer need groups to be added before AddCommand() is called. This provides more flexibility to developers and works better with the use of "init()" for command creation. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
marckhouzam
force-pushed
the
fix/noOrderForGroups
branch
from
09b9899 to
9681b6c
Compare
jpmcb
approved these changes
Oct 24, 2022
If you're up for it I think it would improve the user experience for this popular feature 👍 |
jpmcb
pushed a commit
to jpmcb/cobra
that referenced
this pull request
Oct 24, 2022
Fixes spf13#1831 By moving the check for help group existence to "ExecuteC()" we no longer need groups to be added before AddCommand() is called. This provides more flexibility to developers and works better with the use of "init()" for command creation. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
jpmcb
added a commit
that referenced
this pull request
Oct 24, 2022
Fixes #1831 By moving the check for help group existence to "ExecuteC()" we no longer need groups to be added before AddCommand() is called. This provides more flexibility to developers and works better with the use of "init()" for command creation. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Co-authored-by: Marc Khouzam <marc.khouzam@gmail.com>
|
@marckhouzam please milestone this! |
Thanks! I created a 1.6.1 milestone for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1831
Replaces #1835
By moving the check for help group existence to "ExecuteC()" we no longer need groups to be added before AddCommand() is called. This provides more flexibility to developers and works better with the use of "init()" for command creation.
cc @aawsome