Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for removing group #1911 #1912

Closed

Conversation

valllabh
Copy link

Fixed Missing support for removing group #1911

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2023

CLA assistant check
All committers have signed the CLA.

@marckhouzam marckhouzam added kind/feature A feature request for cobra; new or enhanced behavior area/cobra-command Core `cobra.Command` implementations labels Feb 26, 2023
@marckhouzam marckhouzam added this to the 1.7.0 milestone Feb 26, 2023
@marckhouzam
Copy link
Collaborator

Thanks @valllabh.
When you remove a group I assume you must also remove all subcommands from that group?

So without your PR do I understand correctly that you are able to remove all your sub commands from a group but that then the group appears empty in the help text. Is that right?

If that is the case, do we really need to allow removing groups? Maybe we should simply not display empty groups in the help?

@marckhouzam marckhouzam removed this from the 1.7.0 milestone Feb 27, 2023
@marckhouzam marckhouzam added this to the 1.8.0 milestone Apr 5, 2023
@valllabh
Copy link
Author

Closing. Duplicated to #1997

@valllabh valllabh closed this Jul 23, 2023
@valllabh valllabh deleted the Missing-support-for-removing-group-#1911 branch July 23, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cobra-command Core `cobra.Command` implementations kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants