all: refactor to use %q instead of "%s"

[callthingsoff]

This PR simplifies code using %q rather than "%s".

Please take a look. Thanks.

[marckhouzam]

Looks safe. Thanks!

[marckhouzam]

CI disagrees that it’s safe. I didn’t look at what the error was though.

[callthingsoff]

Thanks. I think it's this code.

fmt.Errorf(`required flag(s) "%s" not set`, strings.Join(missingFlagNames, `", "`))

It is now reverted. Thanks again.

[callthingsoff]

Please take a look at this.

package main

import (
	"fmt"
	"path"
	"path/filepath"
	"strings"
	"time"
)

func main() {
	const fmTemplate = `---
date: %s
title: %q
slug: %s
url: %s
---
`
	filePrepender := func(filename string) string {
		now := time.Now().Format(time.RFC3339)
		name := filepath.Base(filename)
		base := strings.TrimSuffix(name, path.Ext(name))
		url := "/commands/" + strings.ToLower(base) + "/"
		return fmt.Sprintf(fmTemplate, now, strings.Replace(base, "_", " ", -1), base, url)
	}
	fmt.Printf("[%v]\n", filePrepender(`"abc".txt`))
}

The output is

[---
date: 2023-07-21T13:37:27+08:00
title: "\"abc\""
slug: "abc"
url: /commands/"abc"/
---
]

And the original output of "%s" is

[---
date: 2023-07-21T13:38:14+08:00
title: ""abc""
slug: "abc"
url: /commands/"abc"/
---
]

I don't know which style is better. Maybe this PR is unnecessary and I'll close it.

[marckhouzam]

I don't know which style is better. Maybe this PR is unnecessary and I'll close it.

yeah, with the extra escaping being done I see that %q is not exactly “%s”. Although it may be better in some cases let’s avoid changing anything that may affect existing projects.

Thanks anyway.