Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow running persistent run hooks of all parents #2044

Merged
merged 1 commit into from
Oct 22, 2023

Commits on Oct 18, 2023

  1. Feature: allow running persistent run hooks of all parents

    Currently, only one of the persistent pre-runs and post-runs is executed.
    It is always the first one found in the parents chain, starting at this command.
    Expected behavior is to execute all parents' persistent pre-runs and post-runs.
    
    Dependent projects implemented various workarounds for this:
    - manually building persistent hook chains (in every hook).
    - applying some kind of monkey-patching on top of Cobra.
    
    This change eliminates the necessity for such workarounds
    by allowing to set a global variable EnableTraverseRunHooks.
    
    Tickets:
    - spf13#216
    - spf13#252
    
    Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
    vkhoroz committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f1f4087 View commit details
    Browse the repository at this point in the history