Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print errors to stderr in cobra init boilerplate #774

Closed
wants to merge 1 commit into from
Closed

Print errors to stderr in cobra init boilerplate #774

wants to merge 1 commit into from

Conversation

Brcrwilliams
Copy link

This has been a minor annoyance for me with the Cobra codegen tool. Error messages and debugging information ("Using config file:") should be printed to stderr and not stdout.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 18, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
7111305
@umarcor umarcor mentioned this pull request Mar 18, 2019
Merged
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 20, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
73813c0
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 20, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
4cae044
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 20, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
4f88215
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 21, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
8fa6465
@spf13
Copy link
Owner

spf13 commented Jun 7, 2019

I agree. Seems like a small change. @eparis would this have any impact on K8s or other things?

@spf13 spf13 requested review from n10v and eparis June 7, 2019 14:23
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
4f966e8
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
5698f2e
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
db749de
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
bd812c5
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
7eb4c1c
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
21af741
umarcor added a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@umarcor
drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (…
21cccf0 
…spf13#774)

fix: root.go.golden and tpl/main.go
umarcor added a commit to umarcor/cobra that referenced this pull request Jun 7, 2019
@umarcor
drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (…
debcaa3 
…spf13#774)

fix: root.go.golden and tpl/main.go
@umarcor umarcor mentioned this pull request Jun 7, 2019
Closed
@spf13
Copy link
Owner

spf13 commented Jun 8, 2019

@Brcrwilliams if you could, can you resolve the conflicts and I'd be glad to merge this in?

umarcor added a commit to umarcor/cobra that referenced this pull request Jul 11, 2019
@umarcor
drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (…
fe28849 
…spf13#774)

fix: root.go.golden and tpl/main.go
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 11, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
6aed50e
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 23, 2019
@umarcor
drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (…
4b2eb47 
…spf13#774)

fix: root.go.golden and tpl/main.go
umarcor added a commit to umarcor/cobra that referenced this pull request Sep 5, 2019
@umarcor
drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (…
827d619 
…spf13#774)

fix: root.go.golden and tpl/main.go
umarcor added a commit to umarcor/cobra that referenced this pull request Sep 5, 2019
@umarcor
drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (…
b29828f 
…spf13#774)

fix: root.go.golden and tpl/main.go
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 5, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
b6f049b
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 5, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
d2ed75a
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 5, 2019
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
9644e17
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jul 13, 2020
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
fb3e084
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
drop mitchellh/go-homedir (spf13#853), print to stderr in boilerplate (…
467789a 
…spf13#774)

fix: root.go.golden and tpl/main.go
umarcor pushed a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
e36a4fe
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
6985711
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
5714641
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
2de9d0a
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
293b183
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
9b13e07
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
77e7d84
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
d2e7bf2
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
a83e5ce
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
24d5f6d
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
bd0929f
umarcor added a commit to umarcor/cobra that referenced this pull request Aug 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
912cf5f
umarcor added a commit to umarcor/cobra that referenced this pull request Sep 25, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
9b46c07
umarcor pushed a commit to umarcor/cobra that referenced this pull request Sep 25, 2020
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
2c163a5
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 1, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
bc87d55
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 1, 2020
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
78bf2f3
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 14, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
d200ea0
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 14, 2020
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
e56c341
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 18, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
572a54c
umarcor pushed a commit to umarcor/cobra that referenced this pull request Oct 18, 2020
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
728a1a0
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 14, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
e01fced
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 4, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
cfcdfcc
umarcor pushed a commit to umarcor/cobra that referenced this pull request Dec 4, 2020
@Brcrwilliams @umarcor
print errors to stderr in cobra init boilerplate (spf13#774)
2e88b8e
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 29, 2020
@umarcor
print to stderr in boilerplate (spf13#774)
13ac70f
umarcor added a commit to umarcor/cobra that referenced this pull request Jan 30, 2021
@umarcor
print to stderr in boilerplate (spf13#774)
8266f08
umarcor added a commit to umarcor/cobra that referenced this pull request Jan 30, 2021
@umarcor
print to stderr in boilerplate (spf13#774)
213a2a5
umarcor added a commit to umarcor/cobra that referenced this pull request Feb 2, 2021
@umarcor
print to stderr in boilerplate (spf13#774)
2a9bcdd
umarcor added a commit to umarcor/cobra that referenced this pull request Feb 2, 2021
@umarcor
print to stderr in boilerplate (spf13#774)
73b1600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n10v n10v n10v approved these changes

@eparis eparis Awaiting requested review from eparis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Brcrwilliams @CLAassistant @spf13 @umarcor @n10v