Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] [Travis] Execute 'go vet', use stages, use language conf list, add go 1.12.x, update shellcheck #839

Closed
wants to merge 5 commits into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Mar 18, 2019

This PR includes several minor enhancements to .travis.yml:

  • Execute 'go vet' instead of 'go tool vet', to fix the error with go >1.11 (i.e. tip and/or 1.12).
  • Move the job that gets diff of gofmt to a separate stage in Travis, because it is not a test.
  • Use language configuration list instead of explicit entries in matrix.include. This is a more natural way to handle the config in Travis.
  • Run tests against go 1.12.x.
  • Update shellcheck-docker to v0.6.0.

This PR conflicts with #832. I can either rebase on top of @peter-edge's branch, or let him rebase on top of this. @eparis, wdyt?

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2019

CLA assistant check
All committers have signed the CLA.

@umarcor
Copy link
Contributor Author

umarcor commented Mar 18, 2019

Closed in favour of #840.

@umarcor umarcor closed this Mar 18, 2019
@umarcor umarcor deleted the fix-travis-112 branch March 18, 2019 23:47
umarcor added a commit to umarcor/cobra that referenced this pull request Mar 19, 2019
umarcor added a commit to umarcor/cobra that referenced this pull request Mar 19, 2019
umarcor added a commit to umarcor/cobra that referenced this pull request Mar 19, 2019
eparis pushed a commit that referenced this pull request Mar 20, 2019
…ts list... (#840)

* update Example in README.md (#769)

* specify the color as the required arg (#777)

* command: fix typo in docstring of InheritedFlags (#779)

* add istio to the list of projects built with Cobra (#786)

* remove redundant 'else' (#806)

* add mattermost-server as a project built with Cobra (#824)

* update README.md (#826)

Fix the comment: consistent with others

* add uber/prototool as a project built with Cobra (#831)

* fix(ci): use go vet, update to Go 1.12, update shellcheck to v0.4.6 (#832)

* add go.mod and go.sum (#833)

* chore(travis): move 'diff' job to separate stage in Travis (#839)

* chore(travis): use language configuration list instead of explicit entries in matrix.include (#839)

* chore(travis): update shellcheck-docker to v0.6.0 (#839)

* update(README.md): separate projects by commas, instead of using a list

* chore: update viper to v1.3.2 and go-md2man to v1.0.10

* fix: convert CRLF to LF when comparing files

* use kyoh86/richgo to provide colored test outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants