Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

350 add fish completion support #865

Closed
wants to merge 12 commits into from
Closed

350 add fish completion support #865

wants to merge 12 commits into from

Commits on May 22, 2019

  1. add fish completion basics to cobra.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    8e081ca View commit details
    Browse the repository at this point in the history

  2. add helpCommand check to fish completions.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    bbc7416 View commit details
    Browse the repository at this point in the history

  3. add basic tests for fish completion.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    640b79d View commit details
    Browse the repository at this point in the history

  4. support ValidArgs completion of commands in fish.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    575081e View commit details
    Browse the repository at this point in the history

  5. add additional support for argument aliases.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    5697159 View commit details
    Browse the repository at this point in the history

  6. remove oly mention.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    b681855 View commit details
    Browse the repository at this point in the history

  7. use custom function for checking subcommand path.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    0a631b3 View commit details
    Browse the repository at this point in the history

  8. use fish builtin for flag/argument checking.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    9ecb79d View commit details
    Browse the repository at this point in the history

  9. backport __fish_seen_argument.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    2035fda View commit details
    Browse the repository at this point in the history

  10. escape description of commands & flags.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    4f3e5f4 View commit details
    Browse the repository at this point in the history

  11. allow subcommand_path to match even with flags 

    With the old version flags between subcommands
weren't allowed (as it was doing exact match).
This solution is still not perfect (as it uses '.+')
and could potentially swallow other subcommands.
    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    5f46ad3 View commit details
    Browse the repository at this point in the history

  12. deal with unreachable code warning.

    @0robustus1
    0robustus1 authored and David Gillies committed May 22, 2019
    Configuration menu
    Copy the full SHA
    a407b6c View commit details
    Browse the repository at this point in the history