Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit LICENSE file when license is set to none #937

Closed
wants to merge 2 commits into from

Conversation

rhcarvalho
Copy link

Since the documented purpose of --license none is to have no license, creating a project should not create an empty LICENSE file.

@jharshman jharshman added this to the 1.0.0 milestone Oct 7, 2019
@umarcor
Copy link
Contributor

umarcor commented Jan 4, 2020

@rhcarvalho, would you mind rebasing thir PR, please?

Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
Creating a project without a license should not create an empty LICENSE
file.
@rhcarvalho
Copy link
Author

Rebased 🎉

umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Jan 22, 2020
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 3, 2020
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 3, 2020
Creating a project without a license should not create an empty LICENSE
file.
@umarcor umarcor mentioned this pull request Feb 3, 2020
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 20, 2020
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Feb 20, 2020
Creating a project without a license should not create an empty LICENSE
file.
Copy link
Collaborator

@jharshman jharshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great but please trim the changes down to just the license conditional and the test.

umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Mar 1, 2020
Creating a project without a license should not create an empty LICENSE
file.
@rhcarvalho
Copy link
Author

Closing in favor of #1028

@rhcarvalho rhcarvalho closed this Mar 2, 2020
@rhcarvalho rhcarvalho deleted the no-license branch March 2, 2020 17:02
@rhcarvalho rhcarvalho restored the no-license branch March 2, 2020 17:03
umarcor pushed a commit to umarcor/cobra that referenced this pull request Apr 13, 2020
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request Apr 13, 2020
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
Instead of writing to the current working directory, pick a random temp
directory to test the CLI commands, keeping the working directory free
of test side effects.

In some cases the system default temp dir will also have some advantages
like being mounted in an in-memory tmpfs.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
Creating a project without a license should not create an empty LICENSE
file.
umarcor pushed a commit to umarcor/cobra that referenced this pull request May 11, 2020
Creating a project without a license should not create an empty LICENSE
file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants