fix: ensure that testproject is removed even after a failure

[umarcor]

In 984374f a defer func() was added after a possible t.Fatal(err). This PR moves it before, to ensure that testproject files are removed after a failure.

[jharshman]

Looks like a good bug fix @umarcor. Got my 👍but will give others a chance to review the change as well. I know it's not part of your change-set but If you don't mind, I think that defer statement can be simplified.

[umarcor]

Thanks @jharshman!

I know it's not part of your change-set but If you don't mind, I think that defer statement can be simplified.

I wouldn't mind to do so, but I'm sleepy now and I don't understand what you mean. How do you suggest to simplify it? Note that I would apply the simplification to add_test.go too (which is the other file that was modified in 984374f).

[jharshman]

How do you suggest to simplify it?

According to the package docs, os.RemoveAll(path string) doesn't fail when the path doesn't exist. Therefore you should be able to simplify to defer os.RemoveAll(project.AbsolutePath).

ref: https://golang.org/pkg/os/#RemoveAll

[umarcor]

Thanks for the hint @jharshman! I updated the PR accordingly.