Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neovim support #774

Closed
bronzehedwick opened this issue May 8, 2015 · 6 comments · Fixed by #777
Closed

Neovim support #774

bronzehedwick opened this issue May 8, 2015 · 6 comments · Fixed by #777

Comments

@bronzehedwick
Copy link
Contributor

I wanted to try and start a discussion about including support for Neovim. Even though it doesn't have a 1.0 release yet, it brings a lot of exciting features, especially for the plugin ecosystem, while maintaining a lot of backwards compatibility. One plugin in particular, neomake, is very exciting in it's potential for speeding up vim in-editor code checking.

Neovim uses .nvimrc as it's main dotfile, so it can exist alongside vim without conflict. Adding support would probably look like adding an .nvimrc file to spf13 customized for Neovim support, that would only be copied to the home directory if the neovim binary existed on the system.

Of course, the major downside to this is adding something else to support, but I at least wanted to float the idea and see what people thought.
@ghost
Copy link

ghost commented May 8, 2015

did they ever finish supporting lua in plugins? that's the main blocker for me before i give it a shot.

@FiloSpaTeam
Copy link

I started a branch in my fork to have support for NeoVim.
https://github.com/FiloSpaTeam/spf13-vim/tree/neovim

@bronzehedwick
Copy link
Contributor Author

@jrobeson Looks like they haven't completed the lua support for plugins yet, but it's near the top of their TODO, which probably means it'll ship before a 1.0 release.

@FiloSpaTeam thanks for the link! I'll play with that in the mean time.

@FiloSpaTeam
Copy link

You're welcome!! Help is very appreciate 👍

@bronzehedwick
Copy link
Contributor Author

I just ran a test and I am able to use neovim locally with spf13-vim, with bvery few changes. I have a vanilla spf13, and then symlinked .spf13-vim-3/.vimrc to ~/.nvimrc and .spf13-vim-3/.vim to ~/.nvim. After installing neovim python support, everything just works.

bronzehedwick added a commit to bronzehedwick/spf13-vim that referenced this issue May 11, 2015
@bronzehedwick
Preliminary support for neovim
5ff4f6f 
A simple change to support neovim. Fixes spf13#774.
@bronzehedwick bronzehedwick mentioned this issue May 11, 2015
Merged
@ghost
Copy link

ghost commented May 11, 2015

as mentioned in #777, you shouldn't need a .nvimrc .nvim should work

bronzehedwick added a commit to bronzehedwick/spf13-vim that referenced this issue Aug 31, 2015
@bronzehedwick
Preliminary support for neovim
5b7a4a3 
A simple change to support neovim. Fixes spf13#774.

Move nvimrc file inside .nvim directory

Only install neovim support if neovim is being used

Use program_exists function instead of vimscript

Made a hasty mistake and added vimscript to a bash script :X

Neovim not existing no longer stops script

Also correct `endif` to `fi`.

Refactor program_exists naming

Changed `program_exists` to `program_must_exist`, which throws an error which halts the script if the program is not found, and refactored `nvim_exists` to be the more general `program_exists`, which does not throw an error if the program is not found.

Refactor program_exists and program_must_exist

`program_must_exist` uses `program_exists` now, instead of repeating code. Changed `type` to `command -v` in `program_exists` to be more POSIX compliant. Refactored status code conditional in `program_exists` to remove double negatives. Thanks to @mkwmms for the suggestions.
bronzehedwick added a commit to bronzehedwick/spf13-vim that referenced this issue Sep 2, 2015
@bronzehedwick
Preliminary support for neovim
9f78da8 
A simple change to support neovim. Fixes spf13#774.

Move nvimrc file inside .nvim directory

Only install neovim support if neovim is being used

Use program_exists function instead of vimscript

Made a hasty mistake and added vimscript to a bash script :X

Neovim not existing no longer stops script

Also correct `endif` to `fi`.

Refactor program_exists naming

Changed `program_exists` to `program_must_exist`, which throws an error which halts the script if the program is not found, and refactored `nvim_exists` to be the more general `program_exists`, which does not throw an error if the program is not found.

Refactor program_exists and program_must_exist

`program_must_exist` uses `program_exists` now, instead of repeating code. Changed `type` to `command -v` in `program_exists` to be more POSIX compliant. Refactored status code conditional in `program_exists` to remove double negatives. Thanks to @mkwmms for the suggestions.

Preliminary support for neovim

A simple change to support neovim. Fixes spf13#774.

Move nvimrc file inside .nvim directory

Refactor program_exists naming

Changed `program_exists` to `program_must_exist`, which throws an error which halts the script if the program is not found, and refactored `nvim_exists` to be the more general `program_exists`, which does not throw an error if the program is not found.

Refactor program_exists and program_must_exist

`program_must_exist` uses `program_exists` now, instead of repeating code. Changed `type` to `command -v` in `program_exists` to be more POSIX compliant. Refactored status code conditional in `program_exists` to remove double negatives. Thanks to @mkwmms for the suggestions.
@ghost ghost closed this as completed in #777 Sep 2, 2015
robbyoconnor pushed a commit to robbyoconnor/spf13-vim that referenced this issue Feb 12, 2021
@bronzehedwick @robbyoconnor
Preliminary support for neovim
22fec2b 
A simple change to support neovim. Fixes spf13#774.

Move nvimrc file inside .nvim directory

Only install neovim support if neovim is being used

Use program_exists function instead of vimscript

Made a hasty mistake and added vimscript to a bash script :X

Neovim not existing no longer stops script

Also correct `endif` to `fi`.

Refactor program_exists naming

Changed `program_exists` to `program_must_exist`, which throws an error which halts the script if the program is not found, and refactored `nvim_exists` to be the more general `program_exists`, which does not throw an error if the program is not found.

Refactor program_exists and program_must_exist

`program_must_exist` uses `program_exists` now, instead of repeating code. Changed `type` to `command -v` in `program_exists` to be more POSIX compliant. Refactored status code conditional in `program_exists` to remove double negatives. Thanks to @mkwmms for the suggestions.

Preliminary support for neovim

A simple change to support neovim. Fixes spf13#774.

Move nvimrc file inside .nvim directory

Refactor program_exists naming

Changed `program_exists` to `program_must_exist`, which throws an error which halts the script if the program is not found, and refactored `nvim_exists` to be the more general `program_exists`, which does not throw an error if the program is not found.

Refactor program_exists and program_must_exist

`program_must_exist` uses `program_exists` now, instead of repeating code. Changed `type` to `command -v` in `program_exists` to be more POSIX compliant. Refactored status code conditional in `program_exists` to remove double negatives. Thanks to @mkwmms for the suggestions.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preliminary support for neovim bronzehedwick/spf13-vim
2 participants
@bronzehedwick @FiloSpaTeam