Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shougo/neosnippet-snippets. Fixes #539. #551

Merged
merged 2 commits into from
Feb 18, 2014
Merged

Add Shougo/neosnippet-snippets. Fixes #539. #551

merged 2 commits into from
Feb 18, 2014

Conversation

ljani
Copy link
Contributor

@ljani ljani commented Feb 6, 2014

Shougo/neosnippet.vim version 4.1 split the repository into two and the other half is now missing. This causes following errors on Mac (#539) and Cygwin at least:

neosnippet default snippets cannot be loaded.
You must install neosnippet-snippets or disable runtime snippets.

I'm not sure why gVim (on Windows) doesn't warn about this.

This PR adds Shougo/neosnippet-snippets as we're already using the "extra" snippets, so it makes sense to include the default snippets instead of disabling them.

More info of the breaking change: Shougo/neosnippet.vim@5dba6a0

ljani added 2 commits February 6, 2014 20:25
… 4.1 split the repository into two and the other half is now missing, see the PR for details.
@ljani
Copy link
Contributor Author

ljani commented Feb 6, 2014

Meh, managed to add them in the wrong order.. I guess it doesn't make much difference, but it's nice to have proper cosmetics.

@johntyree
Copy link
Collaborator

In .vimrc we specify

            " Use honza's snippets.
            let g:neosnippet#snippets_directory='~/.vim/bundle/vim-snippets/snippets'

does this not handle this issue? I have no errors.

@ljani
Copy link
Contributor Author

ljani commented Feb 11, 2014

Honza's vim-snippets is different from neosnippet-snippets. The line you quoted, enables Honza's snippets, see Shougo/neosnippet towards the end of the page

@johntyree: What OS are you using? gvim on Windows doesn't whine either, but console vim in Cygwin throws the error.

@johntyree
Copy link
Collaborator

@ljani I realize it's a different set of snippets, but I thought it would handle the "default snippets" problem. Perhaps not?

I'm on OSX and Linux, but my own spf13 is heavily modified and not a good reference ;)

@ljani
Copy link
Contributor Author

ljani commented Feb 11, 2014

Ah, sorry, I misunderstood you. Anyway, the default snippets are loaded here (+3 lines) whereas those additional snippets are only loaded here after throwing the error.

The problem should be reproducible on OSX as well, as mentioned in #539. I guess your customizations solve the problem then.

@lukedomanski
Copy link
Contributor

@ljani "I'm not sure why gVim (on Windows) doesn't warn about this"'

Unlike you, I was getting this error on Windows gVim also. These commits solved the issue for me. Though I have not checked for side effects yet.

I don't understand what you an @johntyree were referring to above, do "we" need this commit? If so, why is it sitting so long without being merged?

Cross-ref: #539

spf13 added a commit that referenced this pull request Feb 18, 2014
Add Shougo/neosnippet-snippets. Fixes #539.
@spf13 spf13 merged commit 7565039 into spf13:3.0 Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants