-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen program mapping is now opt-in (as it slows down exits from insert back to normal mode) #559
Conversation
This as it slows down exit from insert mode for many users
@@ -570,7 +574,7 @@ | |||
nnoremap <silent> <leader>gi :Git add -p %<CR> | |||
nnoremap <silent> <leader>gg :SignifyToggle<CR> | |||
"} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed some annoying spaces as well to make the file not show syntax issues
See #510 for discussion of this pull request |
@@ -85,6 +85,13 @@ | |||
" let g:multi_cursor_quit_key='<Esc>' | |||
" Require a special keypress to enter multiple cursors mode | |||
" let g:multi_cursor_start_key='+' | |||
|
|||
" Add mappings for Unix `screen` program. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this comment is already long, but it doesn't say what this option actually does. What are we mapping here? Home and End? Does anyone know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea. I was mostly interested in making them "go away" as they cause an almost second delay when exiting insert mode.
I could easily see simply removing the whole thing!
I don't think we should be focusing on external programs like screen and TMUX and instead leave that to the user.
+1 for removing it entirely. |
Ok. Let me do a pull request removing it entirely. I vote for that too. We need to minimize what we have (spf-vim is on the upper end of content) and it seems like reducing assumption on external flows makes sense |
Ok. Updated pull request: rekendahl@9b23636 Simply removes these mappings. If anyone is using them I hope the chime in |
I followed the history back to where this was introduced. @taxilian if you're still using this, be aware that it's gone now. |
Screen program mapping is now opt-in (as it slows down exits from insert back to normal mode)
To enable screen mapping add
let g:spf13_screen_mapping = 1
in your .vimrc.before