Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen program mapping is now opt-in (as it slows down exits from insert back to normal mode) #559

Merged
merged 2 commits into from
Feb 12, 2014

Conversation

rekendahl
Copy link
Contributor

To enable screen mapping add let g:spf13_screen_mapping = 1 in your .vimrc.before

This as it slows down exit from insert mode for many users
@@ -570,7 +574,7 @@
nnoremap <silent> <leader>gi :Git add -p %<CR>
nnoremap <silent> <leader>gg :SignifyToggle<CR>
"}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed some annoying spaces as well to make the file not show syntax issues

@rekendahl
Copy link
Contributor Author

See #510 for discussion of this pull request

@@ -85,6 +85,13 @@
" let g:multi_cursor_quit_key='<Esc>'
" Require a special keypress to enter multiple cursors mode
" let g:multi_cursor_start_key='+'

" Add mappings for Unix `screen` program.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this comment is already long, but it doesn't say what this option actually does. What are we mapping here? Home and End? Does anyone know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. I was mostly interested in making them "go away" as they cause an almost second delay when exiting insert mode.

I could easily see simply removing the whole thing!

I don't think we should be focusing on external programs like screen and TMUX and instead leave that to the user.

@adambiggs
Copy link

+1 for removing it entirely.

@rekendahl
Copy link
Contributor Author

Ok. Let me do a pull request removing it entirely. I vote for that too. We need to minimize what we have (spf-vim is on the upper end of content) and it seems like reducing assumption on external flows makes sense

@rekendahl
Copy link
Contributor Author

Ok. Updated pull request: rekendahl@9b23636

Simply removes these mappings. If anyone is using them I hope the chime in

@johntyree
Copy link
Collaborator

I followed the history back to where this was introduced. @taxilian if you're still using this, be aware that it's gone now.

johntyree added a commit that referenced this pull request Feb 12, 2014
Screen program mapping is now opt-in (as it slows down exits from insert back to normal mode)
@johntyree johntyree merged commit 1a4fd8b into spf13:3.0 Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants