Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viper cannot be used on appengine #538

Closed
nkovacs opened this issue Jul 23, 2018 · 0 comments · Fixed by #1460
Closed

viper cannot be used on appengine #538

nkovacs opened this issue Jul 23, 2018 · 0 comments · Fixed by #1460
Milestone
v1.14.0

Comments

@nkovacs
Copy link
Contributor

nkovacs commented Jul 23, 2018

Viper imports github.com/fsnotify/fsnotify, which imports unsafe, which is not allowed on appengine.
@arp242 arp242 mentioned this issue Nov 3, 2022
Closed
arp242 added a commit to fsnotify/fsnotify that referenced this issue Nov 4, 2022
@arp242
Don't build on appengine
7ed195f 
AppEngine forbids usage of the unsafe package,

Fixes #534
Fixes spf13/viper#538
@sagikazarmark sagikazarmark added this to the v1.14.0 milestone Nov 6, 2022
@sagikazarmark sagikazarmark mentioned this issue Nov 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

Disable watch on appengine spf13/viper
2 participants
@sagikazarmark @nkovacs