Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Firestore remote provider #836

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

alxmsl
Copy link
Contributor

@alxmsl alxmsl commented Jan 31, 2020

I'm using viper for cloud-native applications. So, etcd and consul are not well solutions for me to configure my applications.
This PR supports Firestore for developers who'd like to use Google Cloud Platform, for example

Additionally, I've updated dependency for crypt library, because looks like github.com/xordataexchange/crypt is dead for a long time. And now this library is been developing in the fork github.com/bketelsen/crypt

@claassistantio
Copy link

claassistantio commented Jan 31, 2020

CLA assistant check
All committers have signed the CLA.

@sagikazarmark
Copy link
Collaborator

Although I'm generally against merging more providers into the Viper core, this is a simple change in a well-shaped PR, so 👍

Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alxmsl

@sagikazarmark sagikazarmark merged commit b31a492 into spf13:master Feb 19, 2020
@sagikazarmark sagikazarmark added this to the 1.7.0 milestone Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants