Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nix support #11

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

add nix support #11

wants to merge 15 commits into from

Conversation

GTrunSec
Copy link

@GTrunSec GTrunSec commented Apr 1, 2022

  • packages
  • Modules
    • server
    • client

@GTrunSec GTrunSec marked this pull request as draft April 1, 2022 09:04
@sphenlee
Copy link
Owner

Hi @GTrunSec , thanks for the contribution.

I have to admit I have no experience with nix so I'm not really able to provide a proper review.
Also, I noticed you're using sed in a few places (to ensure a reproducible build I think?). Feel free to make changes in the code itself to make this easier - the way version info gets embedded is a hack and if there is a better way I'm happy to switch.

@GTrunSec
Copy link
Author

Adding the environment variable of git_hash can be easily solved.

@GTrunSec
Copy link
Author

GTrunSec commented Apr 20, 2022

@blaggacao you can find the example of the config files here https://github.com/sphenlee/waterwheel/blob/main/sample/jobs/complex-dag.yml

At present, I am exploring nix-driver related things. I think the diagram based on petrinets is enough for use. Maybe we can examine the way for funflow in the future. For std flow expectation, I'd instead put them in the backend than wait in a tty for an indeterminate amount of time. Whether it's a c4 model or a jobs dag, it's sufficiently to analyze the data by json.

  • Regrading Add std flow divnix/std#49, Maybe we just need to add a watcher for flow in justfile.
  • std workflow, waterwheel would help us to achieve this motivation.

@GTrunSec
Copy link
Author

GTrunSec commented Apr 20, 2022

@sphenlee Do you know about funflow? you might be interested in this project. I would like to add a notebook for the waterwheel to research the seeable and logical structure of the job, even DC field.

@GTrunSec GTrunSec marked this pull request as ready for review April 20, 2022 04:26
@blaggacao
Copy link

this looks awsome.

@GTrunSec
Copy link
Author

The nix PR works well for now. @sphenlee. Next, I'm going to talk about other features which need to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants