Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor input handling #290

Open
fatcerberus opened this issue Nov 8, 2018 · 1 comment
Open

Refactor input handling #290

fatcerberus opened this issue Nov 8, 2018 · 1 comment
Labels
internal refactor
Milestone
v6.0.0

Comments

@fatcerberus
Copy link
Member

Writing the code changes in fe1aee1 made me realize that the current mouse handling logic in input.c is pretty clunky. It assumes a fixed set of mouse buttons, and a mouse wheel that only scrolls vertically. As many modern mice are as complex as gamepads, this code should be refactored to be more flexible.
@fatcerberus fatcerberus added this to the v5.3.0 milestone Nov 8, 2018
fatcerberus added a commit that referenced this issue Nov 8, 2018
@fatcerberus
Refactor mouse button handling code
f1ddcda 
No more special cases for each button.  The large amount of
copy-and-paste code was really starting to get on my nerves, especially
once I added support for the back and forward buttons.  This file could
still use more refactoring, so I'm leaving #290 open.
@fatcerberus fatcerberus modified the milestones: v5.3.0, v6.0.0 Nov 25, 2018
@fatcerberus
Copy link
Member Author

To be honest, input.c could use to be split off into separate source files for keyboard, mouse and joystick instead of the huge monolithic mess it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal refactor
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
1 participant
@fatcerberus