Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Pages deployment, update remaining references to old repo and TravisCI, add more pre-commit hooks #118

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

Holzhaus
Copy link
Collaborator

@Holzhaus Holzhaus commented Oct 4, 2024

No description provided.

@Holzhaus Holzhaus changed the title Fix GitHub Pages deployment and update remaining references to old repo and TravisCI Fix GitHub Pages deployment, update remaining references to old repo and TravisCI, add more pre-commit hooks Oct 4, 2024
@Holzhaus Holzhaus force-pushed the deploy-pages branch 2 times, most recently from 9e451bf to 5149981 Compare October 4, 2024 16:27
@Holzhaus Holzhaus merged commit 5e6882b into main Oct 4, 2024
21 checks passed
@BurningEnlightenment
Copy link
Member

BurningEnlightenment commented Oct 4, 2024

@Holzhaus I'd suggest splitting release related jobs into a separate workflow and include (or replace the current condition with) the github.ref_protected condition.

@Holzhaus Holzhaus deleted the deploy-pages branch October 4, 2024 16:59
@Holzhaus
Copy link
Collaborator Author

Holzhaus commented Oct 4, 2024

Good point, could you open a PR?

@BurningEnlightenment
Copy link
Member

Sure, will do but later this weekend. I also planned to revise the issue labels and create a project board.

@Holzhaus
Copy link
Collaborator Author

Holzhaus commented Oct 4, 2024

Btw, I'm also not sure if the PyPI deployment work yet. We might need to look into that, too. I was mainly concerned with getting GitHub Pages working because without it the documentation is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants