Adjust the config loader import to support towncrier >= 22.8.0rc1
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webknjaz, does this PR look good to you? Thanks! :) |
|
It seems fine but I don't like reviewing from phone because I may miss the bigger picture so I'll probably get to it tomorrow when I have access to my laptop. I won't be cutting a release from phone anyway. Plus, the next release will likely wait for the other two open PRs to be complete first. |
|
Thank you for the quick follow up - this sounds good to me! |
webknjaz
reviewed
Aug 31, 2022
webknjaz
changed the title
towncrier >= 22.8.0rc1
|
Thank you! |
|
This has been released in v0.3.0a0: https://pypi.org/project/sphinxcontrib-towncrier/0.3.0a0/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements compatibility with the newly released
towncrier >= 22.8.0rc1. Since the extension relies on the Towncrier's private API, this sort of thing is bound to happen time to time. It is solved by using a fallback import logic.This change also adds the said Towncrier version to the CI matrix.
Fixes #60.