Sidebar little improvement #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quick search bar and button in sidebar is splited in two lines which looks not so nice. This commit make them in one line.
…ight For fixed sidebar, the content out of page will not able to show. Add a scrollbar for this situation so that users can scroll down and see that content.
|
Is there any reason of putting aside this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure search input bar and button in one line
The quick search bar and button in sidebar is splited in two lines which looks not so nice. Make them in one line.
Before:
After:
add scrollbar for fixed sidebar if it's height is bigger than page height
For fixed sidebar, the content out of page will not able to show. Add a scrollbar for this situation so that users can scroll down and see that content.
Before:
After:
