Support glob-style operations (rebase) #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhgoebbert
changed the title
AA-Turner
reviewed
Sep 3, 2024
AA-Turner
reviewed
Sep 3, 2024
AA-Turner
reviewed
Sep 3, 2024
| @@ -19,9 +20,28 @@ def __repr__(self): | |||
|
|
|||
| def __call__(self, path): | |||
| """Determine if 'path' should be ignored.""" | |||
| # Return the full path so we make sure we handle relative paths OK | |||
| path_expanded = os.path.abspath(path) | |||
There was a problem hiding this comment.
We should prefer pathlib for path operations
Comment on lines
46
to
47
| if fnmatch.fnmatch(path, pattern): | ||
| return True |
There was a problem hiding this comment.
Is there a way to merge fnmatch and glob?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase of #123
This PR adds support for glob-module-style pattern matching, so you should be able to do
--ignore '**/*ignore*.txt'or--ignore '**/ignore'(do not forget the ticks or your shell might expand the*) and it should just work.ATTENTION: You still need to add the patterns to your
conf.py->exclude_patterns = [<..>]to ensure Sphinx does not read the files/directories.