confoverrides are not respected for theme configuration

[chrisjsewell]

Describe the bug

Basically, there needs to be a slight amendment to #10079

cc @pradyunsg

How to Reproduce

I come across this when running tests with sphinx fixtures

pytest_plugins = 'sphinx.testing.fixtures'

@pytest.mark.sphinx('html', confoverrides={'pygments_dark_style': 'other'})
def test_html4_output(app, status, warning):
   # but pygments_dark_style wil not be set
    app.build()

Expected behavior

No response

Your project

furo

Screenshots

No response

OS

any

Python version

any

Sphinx version

4.3.2

Sphinx extensions

No response

Extra tools

No response

Additional context

No response

[pradyunsg]

You need Sphinx 4.4.0. Can you reproduce with that?

[chrisjsewell]

You need Sphinx 4.4.0. Can you reproduce with that?

Yep: it picks up config in the conf.py (what the PR fixed) but not confoverrides (what the PR did not fix)

[benjaoming]

I'm pretty sure that I have the same issue for a config value added to an extension. The conf value is added with app.add_config_value but defining it in confoverrides does not have an effect.

(using Sphinx 6.x)

[AA-Turner]

See #10079.

[AA-Turner]

Overrides for theme configuration options (via --define, -D, etc) should now work properly following #11855.

A