Add configuration option jquery_use_sri and bump to 4.0.0
#14
Conversation
tests/test_jquery_installed.py
Outdated
| @@ -32,7 +32,7 @@ def inner(**kwargs): | |||
| @pytest.mark.skipif(sphinx.version_info[:2] < (6, 0), | |||
| reason="Requires Sphinx 6.0 or greater") | |||
| def test_jquery_installed_sphinx_ge_60(blank_app): | |||
| out_dir = blank_app(confoverrides={"extensions": ["sphinxcontrib.jquery"]}) | |||
| out_dir = blank_app(confoverrides={"extensions": ["sphinxcontrib.jquery"], "jquery_cors_enable": True}) | |||
There was a problem hiding this comment.
Setting jquery_cors_enable here doesn't seem to work.
I'm suspecting this could be the same as sphinx-doc/sphinx#10120 ?
There was a problem hiding this comment.
I've now tested on a local documentation build that this setting actually has an effect :)
|
@AA-Turner would you be able to have a look here? |
|
Ping @AA-Turner ? |
|
@AA-Turner if you accept that I co-maintain the PyPi package, I can also release this. |
|
@AA-Turner Anything we can do to move this forward? We're happy to help maintain this over at RTD, if you give us permissions. We have lots of users with various needs from Sphinx, and we want to make sure we can help them move forward with changes, and not burden you to manage it. Happy to push this forward on our side, if that makes sense. |
AA-Turner
changed the title
jquery_cors_enable and bump to 4.0.0jquery_use_sri and bump to 4.0.0
What's your PyPI username? A |
|
@AA-Turner it's |
Sorry, suggesting to use
hashwas on me, I was naive to think that we could add something that wasn't exactly the same as before without breaking something eventually 😄Fixes issue in readthedocs/sphinx_rtd_theme#1420
I've also added readthedocs/sphinx_rtd_theme#1421