-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jinja 2 imports have been deprecated #10291
Comments
What version of Jinja2 does your upgrade end up installing? I can't replicate this bug here. My system (on a blank docs project started via
It's possible that this import issue has already been addressed by a version of Sphinx between your 3.5.4 and 4.4.0? I can confirm that, via use of iPython, the import error with Jinja2 3.1.0 does appear:
|
Sorry, I'm wrong. I think that may be from the most recent working container. |
Pinning to |
@pllim Yes, I was wrong. I updated my original comment. I was mistakenly looking at our last successful container build. |
Apologies, I thought I was on the latest Sphinx, as this was a new virtual environment. The bug goes away when I install the latest Sphinx so it must have been fixed somewhere along the way. I tried 4.0.0 and 4.0.1 but they require Jinja2<3.0. With Sphinx 4.0.2 the problem goes away, so this ticket can be closed. Many thanks for your help. |
@jontwo This threw me for a loop too. I was on 2.4.4. |
Re: #10291 (comment) -- Forgot to say our project is pinning to |
Ref: sphinx-doc/sphinx#10291 Note: jinja2 is not a requirement that we need to directlys specify.
Ref: sphinx-doc/sphinx#10291 Note: jinja2 is not a requirement that we need to directlys specify.
An update of Jinja2 caused Sphinx 3.5.4 to break. Our docs seem to build fine (i.e. with the same warnings/errors as before) with Sphinx 4.4.0, so it's time to upgrade. The issue itself is described in sphinx-doc/sphinx#10291
sphinx-doc/sphinx#10291 readthedocs/readthedocs.org#9038 Signed-off-by: David Galloway <dgallowa@redhat.com>
sphinx-doc/sphinx#10291 readthedocs/readthedocs.org#9038 Signed-off-by: David Galloway <dgallowa@redhat.com> (cherry picked from commit 7bd79ed)
This should get around an import change in jinja2==3.1 that sphinx doesn't seem to support yet. See sphinx-doc/sphinx#10291 RE:natcap#933
- Fixed that doc build failed due to the latest release of Jinja2 breaks Sphinx (sphinx-doc/sphinx#10291)
# Workaround for sphinx-doc/sphinx#10291 Jinja2==2.11.3 MarkupSafe==2.0.1
Related: sphinx-doc/sphinx#10291 Fixes: https://tracker.ceph.com/issues/55294 Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Required to resolve failing CI pipeline due to problem reported in: sphinx-doc/sphinx#10291
Required to resolve failing CI pipeline due to problem reported in: sphinx-doc/sphinx#10291
fails because of: sphinx-doc/sphinx#10291
See [here](sphinx-doc/sphinx#10291) for details
* doc: dpgen run machine parameters * unpin sphinx Fix sphinx-doc/sphinx#10291 (comment)
Describe the bug
There is an
ImportError
when using Sphinx with the latest version of Jinja2.How to Reproduce
On any project:
You get the error:
Expected behavior
Sphinx builds without error.
Your project
This will work on any project
Screenshots
No response
OS
Rocky Linux 8.5
Python version
3.8.8
Sphinx version
3.5.4
Sphinx extensions
No response
Extra tools
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: