-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a 'search field' component for themes #11045
Conversation
Please note that the sphinx/sphinx/themes/basic/static/sphinx_highlight.js Lines 99 to 110 in cc314f1
You might want to duplicate this for your Alternatively, you might be able to just re-use the |
eb78b33
to
ec407a6
Compare
searchfield.html is similar to the existing searchbox.html, but does not have the heading "Quick Search". Instead, it uses "Search" as a placeholder text. This gives a cleaner and less cluttered appearance. The searchfield component is added to the basic theme and thus can be used in any derivative theme. It is not used by default for backward compatibility. The searchfield compenent is made the default in the new sphinx13 theme. CSS adaptions ensure that the top of the search field is aligned with the top of the main content.
ec407a6
to
6f67001
Compare
Thanks for the feedback. I've gone back to |
Ping @mgeier. I've addressed your comment and believe this is ready to go. |
Yes, thanks, my comment has been fully addressed. However, I'm not the right person to approve or reject this PR as a whole. |
ping @AA-Turner. You approved the fundamental idea in #10791 (comment). Would you be willing to review? Thanks. |
Thanks! A |
This has been added in sphinx-doc/sphinx#11045.
Feature or Bugfix
Purpose
searchfield.html is similar to the existing searchbox.html, but does not have the heading "Quick Search". Instead, it uses "Search" as a placeholder text. This gives a cleaner and less cluttered appearance.
Before:
After:
Detail
The searchfield component is added to the basic theme and thus can be used in any derivative theme. It is not used by default for backward compatibility. Also searchbox.html was deliberately not modified for backward compatibility.
The searchfield component is made the default in the new sphinx13 theme.
CSS adaptions ensure that the top of the search field is aligned with the top of the main content.