Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-structure the linkcheck builder #11499

Merged
merged 13 commits into from
Jul 22, 2023

Conversation

AA-Turner
Copy link
Member

cc: @jayaddison

This PR re-organises and re-structures the linkcheck builder.

Of note:

  • All functions defined within functions are factored out into top-level functions or class methods
  • Classes and methods have been re-arranged (Builder, PostTransform, Checker, Worker)
  • TLS verification on sphinx.util.requests has been changed to not pass the Config object all the way down
  • The Hyperlink object now stores the document path
  • BuildEnvironment and Config objects are used to extract properties and are not stored as class attributes

A

@AA-Turner AA-Turner self-assigned this Jul 22, 2023
@AA-Turner AA-Turner merged commit d71c781 into sphinx-doc:master Jul 22, 2023
26 checks passed
@jayaddison
Copy link
Contributor

@AA-Turner is the removal of the requests version from the Sphinx user-agent string an intentional part of this changeset?

Everything else looks good to me; I have one or two minor suggestions that I'll open as a separate pull request.

@AA-Turner AA-Turner deleted the linkcheck-refactor branch August 7, 2023 21:27
@AA-Turner AA-Turner added this to the 7.2.0 milestone Aug 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants