Add versionremoved directive
#11905
Merged
Add versionremoved directive
#11905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
CAM-Gerlach
reviewed
Jan 21, 2024
There was a problem hiding this comment.
Not a maintainer here ofc, and personally I'm working on a suite of much more capable directives to replace the upstream builtin version* suite with CPython's deprecated-removed as a basis (which more or less already replaces this), but it seems eminently sensible and straightforward, IMO, to add a versionremoved to the base suite to parallel the others. A few minor comments.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
AA-Turner
reviewed
Jan 21, 2024
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Thanks! |
|
Thanks @AA-Turner ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
versionremoveddirective, for when removing features.versionadded,versionchanged, anddeprecated.Relates