Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML search] Add test coverage to prepare for anticipated partial-match refactoring. #12592

Closed
wants to merge 1 commit into from
Closed

[HTML search] Add test coverage to prepare for anticipated partial-match refactoring. #12592

wants to merge 1 commit into from

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring / preparation

Purpose

  • Additional test coverage for HTML search partial matching, intended to provide some safety guards before a refactoring in the implementation.

Detail

  • Nitpick: also update one of the JS test RST documents to clarify that partial-matching is not solely about prefix-matching.

Relates

@jayaddison jayaddison requested a review from wlach July 15, 2024 22:00
@jayaddison jayaddison mentioned this pull request Jul 16, 2024
Closed
3 tasks
@jayaddison
Copy link
Contributor Author

Superseded-by / included-in #12596.

@jayaddison jayaddison closed this Jul 20, 2024
@jayaddison jayaddison deleted the issue-12045-prep/additional-partial-match-test-coverage branch July 20, 2024 21:31
@jayaddison jayaddison mentioned this pull request Aug 11, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wlach wlach Awaiting requested review from wlach

Assignees
No one assigned
Labels
html search internals:refactoring type:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayaddison