Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert latin_terms to a set #12995

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Convert latin_terms to a set #12995

merged 1 commit into from
Oct 10, 2024

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner added this to the 8.1.0 milestone Oct 10, 2024
@AA-Turner AA-Turner merged commit 705d5dd into sphinx-doc:master Oct 10, 2024
23 checks passed
@AA-Turner AA-Turner deleted the latin_terms branch October 10, 2024 13:23
jayaddison
jayaddison reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 👍

@jayaddison
Copy link
Contributor

@AA-Turner possibly worth a changelog entry? (potentially relevant for folks building large and/or many localized projects?)

@AA-Turner
Copy link
Member Author

There's one already:

"Significantly improve performance when building the search index for Chinese languages."

Are you suggesting changes?

A

@AA-Turner AA-Turner mentioned this pull request Oct 10, 2024
Closed
@jayaddison
Copy link
Contributor

Oops, I'm not sure how I missed that; no, that looks fine - thanks!

@mattwang44 mattwang44 mentioned this pull request Oct 11, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jayaddison jayaddison jayaddison left review comments

Assignees
No one assigned
Labels
type:performance
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @jayaddison