Fix #4019: exception treatment for AttributeError stopping make process

[dpizetta]

Subject: AttributeError/ValueError exceptions are stopping make process

Feature or Bugfix

• Bugfix

Purpose

• These should not stop make process, after all, the warning about missing module is still showed.

Detail

• Insert treatment for attribute error when trying to get group attribute from a None object. It is caused by a not found module name inserted in inheritance diagram.
• Add author
• Add changes
• Add tests
• Catch ValueError when importing for compatibility with Python 2.7 (ImportError for Python 3)

Relates

• inheritance_diagram AttributeError: 'NoneType' object has no attribute 'groups' #4019

[tk0miya]

Could you add a testcase please?

[tk0miya]

How about this? It would be better to check the matched or not before calling group() to me.

matched = module_sig_re.match(objname)  # type: ignore
if not matched:
    return None

modname, attrname = matched.groups()
...

[dpizetta]

Yeh, really better :) And I will provide the test.

[dpizetta]

It should be ok now. Those test will fail with no fixed version and passes from now. Tks

[dpizetta]

I notice the test fail for Python 2.7. In 2.7 it raises a ValueError for importing the module named "..unknown", but in Python 3 it raises ImportError. I believe the best solution is to catch both of them:

...
except (ImporError, ValueError): 
...

[tk0miya]

+1 for catching ValueError!

[tk0miya]

Thank you for your contribution!