-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6149: LaTeX: :index: role titles causes build error of LaTeX #6152
Conversation
ddece25
to
6202b36
Compare
Codecov Report
@@ Coverage Diff @@
## 1.8 #6152 +/- ##
==========================================
+ Coverage 82.25% 82.25% +<.01%
==========================================
Files 308 308
Lines 40678 40690 +12
Branches 6284 6287 +3
==========================================
+ Hits 33458 33471 +13
Misses 5832 5832
+ Partials 1388 1387 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only commented on a docstring. There is not too much time penalty from another transform?
6202b36
to
05d3e37
Compare
It takes 0.04-0.05 seconds for our Sphinx document. docutils' transform process is very lightweight. So no worries :-) |
good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you always :-) |
Feature or Bugfix
Purpose