Fix #8099: autodoc: NameError is raised when script uses TYPE_CHECKING #8108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
8099_NameError_for_TYPE_CHECKING
branch
from
0bf5143
to
53b17f2
Compare
…PE_CHECKING `typing.get_type_hints()` raises NameError when the target object contains unresolavable type annotation (ex. TYPE_CHECKING). This handles the exception and use unresolved annotations for type hints.
tk0miya
force-pushed
the
8099_NameError_for_TYPE_CHECKING
branch
from
53b17f2
to
611fff9
Compare
|
Is there any way to get resolved annotations with |
|
Please post your super cool patch! |
|
Is that another way of saying "No, but we could if you implemented it"? If not, I don't understand your last message. |
|
Yes. I don't have the knowledge to implement it. So somebody's help is needed to realize it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
typing.get_type_hints#8099typing.get_type_hints()raises NameError when the target objectcontains unresolavable type annotation (ex. TYPE_CHECKING). This
handles the exception and use unresolved annotations for type hints.